chore(snowflake): add more randomness in server id fallback#60612
Open
Altahrim wants to merge 1 commit into
Open
chore(snowflake): add more randomness in server id fallback#60612Altahrim wants to merge 1 commit into
Altahrim wants to merge 1 commit into
Conversation
Altahrim
added
enhancement
2. developing
Collaborator
Author
|
/backport to stable34 |
Collaborator
Author
|
/backport to stable33 |
Altahrim
added
3. to review
Altahrim
requested review from
ArtificialOwl,
artonge,
leftybournes and
salmart-dev
and removed request for
a team
artonge
approved these changes
May 20, 2026
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
chore/server_id_entropy
branch
from
2f4a47d to
37385db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRC32 hash function can easily lead to collisions when based on hostname (and even using random strings).
Here is an example which generates a lot of duplicated server IDs from different fake hostnames:
With
$a=bin2hex(random_bytes(10));I also spotted one collision with CRC32.Even if it's only used as a fallback, XXH32 sounds like a better alternative.
Performance
XXH32 should be faster but we need to convert to int:
It's quite close :)
Checklist
3. to review, feature component)stable32)AI (if applicable)